Added querySystemLimits for CSI spec 1.6 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijaKakde
changed the title
VamsiSiddu-7
suggested changes
Oct 17, 2023
system_limit.go
Outdated
|
|
||
| func (c *Client) GetSystemLimits() (syslimit *types.Limit, err error) { | ||
| defer TimeSpent("GetSystemLimits", time.Now()) | ||
| var e emptyBody |
There was a problem hiding this comment.
same here instead of e give some meaningful variable name
system_limit.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| return syslimit, nil |
system_limit.go
Outdated
| // GetMaxVol returns max volume size in GB | ||
| func (c *Client) GetMaxVol() (sys string, err error) { | ||
| defer TimeSpent("GetMaxVol", time.Now()) | ||
| maxlimitType, err := c.GetSystemLimits() |
VamsiSiddu-7
suggested changes
Oct 17, 2023
types/v1/types.go
Outdated
| } | ||
|
|
||
| // SystemLimitEntryList defines struct for system limit entryList | ||
| type Limit struct { |
There was a problem hiding this comment.
I think it will be good to rename it to QuerySystemLimitsResponse
types/v1/types.go
Outdated
| @@ -1738,3 +1738,15 @@ type MDMQueueCommandDetails struct { | |||
| TargetEntityIdentifier string `json:"targetEntityIdentifier,omitempty"` | |||
| AllowedPhase string `json:"allowedPhase,omitempty"` | |||
| } | |||
|
|
|||
| // QuerySystemLimits defines struct for query system limits | |||
| type QuerySystemLimits struct { | |||
There was a problem hiding this comment.
rename it to SystemLimit
system_limit.go
Outdated
| types "github.com/dell/goscaleio/types/v1" | ||
| ) | ||
|
|
||
| type QuerySystemLimitsParam struct { |
There was a problem hiding this comment.
move this to types/v1 types.go because all the types are defined there only
system_limit.go
Outdated
| // GetMaxVol returns max volume size in GB | ||
| func (c *Client) GetMaxVol() (systemLimits string, err error) { | ||
| defer TimeSpent("GetMaxVol", time.Now()) | ||
| maxLimitType, err := c.GetSystemLimits() |
There was a problem hiding this comment.
change the variable name to systemLimits
system_limit.go
Outdated
| return "", err | ||
| } | ||
|
|
||
| for _, systemType := range maxLimitType.SystemLimitEntryList { |
system_limit.go
Outdated
|
|
||
| for _, systemType := range maxLimitType.SystemLimitEntryList { | ||
|
|
||
| if systemType.Type == "volumeSizeGb" { |
system_limit.go
Outdated
| } | ||
|
|
||
| // GetMaxVol returns max volume size in GB | ||
| func (c *Client) GetMaxVol() (systemLimits string, err error) { |
There was a problem hiding this comment.
This should return MaxVolumeSize not systemLimits change it.
VamsiSiddu-7
approved these changes
Oct 17, 2023
|
please re run the integration and unit tests to make sure nothing is breaking |
suryagupta4
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added querySystemLimits for CSI spec 1.6
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Tested the changes using integartion test and unit test
{"maxVal":"512","description":"Total Number of concurrent Move Pairs operations","type":"concurrentMovePairsOperations"},{"maxVal":"65536","minVal":"8","description":"Single replication volume size in GB","type":"replicationVolumeSizeGb"},{"maxVal":"262143","description":"Number of mappings between volumes and hosts","type":"replicationPairsPerReplicationConsistencyGroup"},{"maxVal":"512","description":"Number of host connections (IO controllers) per SDT","type":"ioControllersPerSdt"},{"maxVal":"128","description":"Depth of IO controller queue","type":"ioControllersQueueDepth"},{"maxVal":"32","description":"Number of IO controller queues","type":"ioControllersNumQueues"},{"maxVal":"8","description":"Number of paths per volume","type":"pathsPerVolume"},{"maxVal":"16","description":"Number of connections per host per protection domain","type":"connectionsPerHostPerProtectionDomain"},{"maxVal":"65519","description":"Number of host connections (IO controllers) per SYSTEM","type":"ioControllersPerSystem"}]}
0
1048576
max volume size in volumeSizeGb 1048576